You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2010/04/20 16:22:50 UTC
[jira] Created: (MATH-365) Issue with
"SmoothingBicubicSplineInterpolator"
Issue with "SmoothingBicubicSplineInterpolator"
-----------------------------------------------
Key: MATH-365
URL: https://issues.apache.org/jira/browse/MATH-365
Project: Commons Math
Issue Type: Bug
Affects Versions: 2.1
Reporter: Gilles
Priority: Minor
I figured out that the name of this class is misleading as the implementation doesn't perform the intended smoothing.
In order to solve this issue, I propose to:
# deprecate the "SmoothingBicubicSplineInterpolator" class
# create a "BicubicSplineInterpolator" class (similar to the above class but with the useless code removed)
# remove the "SmoothingBicubicSplineInterpolatorTest" class
# add a "BicubicSplineInterpolatorTest" with essentially the same contents as the above one
Then I would also add a new "SmoothingPolynomialBicubicSplineInterpolator" where I used the "PolynomialFitter" class to smooth the input data along both dimensions before the interpolating function is computed.
Does someone object to these changes?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-365) Issue with
"SmoothingBicubicSplineInterpolator"
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859022#action_12859022 ]
Luc Maisonobe commented on MATH-365:
------------------------------------
removing the test class would badly impact test coverage, so it would be better to simply deprecae it also and to remove the library class and its associated test class together when releasing 3.0
> Issue with "SmoothingBicubicSplineInterpolator"
> -----------------------------------------------
>
> Key: MATH-365
> URL: https://issues.apache.org/jira/browse/MATH-365
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Gilles
> Priority: Minor
>
> I figured out that the name of this class is misleading as the implementation doesn't perform the intended smoothing.
> In order to solve this issue, I propose to:
> # deprecate the "SmoothingBicubicSplineInterpolator" class
> # create a "BicubicSplineInterpolator" class (similar to the above class but with the useless code removed)
> # remove the "SmoothingBicubicSplineInterpolatorTest" class
> # add a "BicubicSplineInterpolatorTest" with essentially the same contents as the above one
> Then I would also add a new "SmoothingPolynomialBicubicSplineInterpolator" where I used the "PolynomialFitter" class to smooth the input data along both dimensions before the interpolating function is computed.
> Does someone object to these changes?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MATH-365) Issue with
"SmoothingBicubicSplineInterpolator"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-365.
-------------------------
Fix Version/s: 2.2
Resolution: Fixed
revision 936295.
> Issue with "SmoothingBicubicSplineInterpolator"
> -----------------------------------------------
>
> Key: MATH-365
> URL: https://issues.apache.org/jira/browse/MATH-365
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Gilles
> Priority: Minor
> Fix For: 2.2
>
>
> I figured out that the name of this class is misleading as the implementation doesn't perform the intended smoothing.
> In order to solve this issue, I propose to:
> # deprecate the "SmoothingBicubicSplineInterpolator" class
> # create a "BicubicSplineInterpolator" class (similar to the above class but with the useless code removed)
> # remove the "SmoothingBicubicSplineInterpolatorTest" class
> # add a "BicubicSplineInterpolatorTest" with essentially the same contents as the above one
> Then I would also add a new "SmoothingPolynomialBicubicSplineInterpolator" where I used the "PolynomialFitter" class to smooth the input data along both dimensions before the interpolating function is computed.
> Does someone object to these changes?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.