[jira] Updated: (HADOOP-4210) Findbugs warnings are printed related to equals implementation of several classes

["Robert Chansler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-4210:
------------------------------------

    Release Note: 
Changed public class org.apache.hadoop.mapreduce.ID to be an abstract class. Removed from class org.apache.hadoop.mapreduce.ID the methods  public static ID read(DataInput in) and public static ID forName(String str).


  was:
The incompatible changes includes:
Following are the incompatible changes:
- public class org.apache.hadoop.mapreduce.ID is changed to an abstract class
- Following methods from the class org.apache.hadoop.mapreduce.ID is removed:
  public static ID read(DataInput in) 
  public static ID forName(String str) 


    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Reviewed, Incompatible change])

Edit release note for publication.

> Findbugs warnings are printed related to equals implementation of several classes
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-4210
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4210
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4210.patch, HADOOP-4210.patch, HADOOP4210.patch
>
>
> During compilation - findbugs generates several warnings that indicates bugs in the implementation of equals method. One of the example of this report is:
> Bug type EQ_GETCLASS_AND_CLASS_CONSTANT (click for details)
> In class org.apache.hadoop.mapred.ID
> In method org.apache.hadoop.mapred.ID.equals(Object)
> At ID.java:[line 66]
> Value doesn't work for subtypes
> This class has an equals method that will be broken if it is inherited by subclasses. It compares a class literal with the class of the argument (e.g., in class Foo it might check if Foo.class == o.getClass()). It is better to check if this.getClass() == o.getClass().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.