You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by da...@apache.org on 2024/09/18 01:09:10 UTC
(kafka) 01/01: MINOR: Log pending join members
This is an automated email from the ASF dual-hosted git repository.
dajac pushed a commit to branch minor-log-pending-members
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit 6ad68fa038444ad142ec962666353c6e4113a19e
Author: David Jacot <dj...@confluent.io>
AuthorDate: Wed Sep 18 01:08:31 2024 +0000
MINOR: Log pending join members
---
.../org/apache/kafka/coordinator/group/GroupMetadataManager.java | 2 +-
.../org/apache/kafka/coordinator/group/classic/ClassicGroup.java | 7 +++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
index 1a11d0c08da..2a48c87c32d 100644
--- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -4043,7 +4043,7 @@ public class GroupMetadataManager {
if (!group.hasAllMembersJoined()) {
log.debug("Cannot complete join phase of group {} because not all the members have rejoined. " +
"Members={}, AwaitingJoinResponses={}, PendingJoinMembers={}.",
- group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), group.numPendingJoinMembers());
+ group.groupId(), group.numMembers(), group.numAwaitingJoinResponse(), String.join(",", group.pendingJoinMembers()));
return EMPTY_RESULT;
}
diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
index 907380289e6..45fffdee65b 100644
--- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
+++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
@@ -609,6 +609,13 @@ public class ClassicGroup implements Group {
return pendingJoinMembers.contains(memberId);
}
+ /**
+ * @return The set of pending join members.
+ */
+ public Set<String> pendingJoinMembers() {
+ return Collections.unmodifiableSet(pendingJoinMembers);
+ }
+
/**
* Add a pending member.
*