You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dzhigimont (via GitHub)" <gi...@apache.org> on 2023/03/15 09:09:35 UTC
[GitHub] [spark] dzhigimont opened a new pull request, #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
dzhigimont opened a new pull request, #40436:
URL: https://github.com/apache/spark/pull/40436
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added `show_counts` parameter for DataFrame.info
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When pandas 2.0.0 is released, we should match the behavior in pandas API on Spark.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Changed the name of the parameter `null_counts` to `show_counts` of the method DataFrame.info
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1523814336
cc @itholic @zhengruifeng @xinrong-meng if you find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
URL: https://github.com/apache/spark/pull/40436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1700029755
LGTM.
Seems like the CI failure is not related to this change. Could you retrigger the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1705801677
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1469882286
cc @itholic and @Yikun if you find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1667094146
Also, please update the migration guide as mentioned https://github.com/apache/spark/pull/40370.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1692633827
Gentle ping @dzhigimont
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1705044778
> LGTM.
>
> Seems like the CI failure is not related to this change. Could you retrigger the CI?
Sure, rebased from master and retriggered tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40436:
URL: https://github.com/apache/spark/pull/40436#discussion_r1310962045
##########
python/pyspark/pandas/indexes/base.py:
##########
@@ -289,7 +289,7 @@ def _summary(self, name: Optional[str] = None) -> str:
if name is None:
name = type(self).__name__
- return "%s: %s entries%s" % (name, total_count, index_summary)
+ return "%s: %s entries%s" % (name, int(total_count), index_summary)
Review Comment:
Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1699174357
> Think we should add some tests for new parameter.
>
> Also, please update the migration guide as mentioned from #40370.
The migration guide was updated and new tests for info method is implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40436:
URL: https://github.com/apache/spark/pull/40436#discussion_r1310717375
##########
python/pyspark/pandas/indexes/base.py:
##########
@@ -289,7 +289,7 @@ def _summary(self, name: Optional[str] = None) -> str:
if name is None:
name = type(self).__name__
- return "%s: %s entries%s" % (name, total_count, index_summary)
+ return "%s: %s entries%s" % (name, int(total_count), index_summary)
Review Comment:
When I was writing tests for the info method I found out that it prints different outputs and the difference was that pandas return:
```
Index: 9 entries, 0.6658222030375259 to 0.7862583284518239
Data columns (total 2 columns):
# Column Non-Null Count Dtype
--- ------ -------------- -----
0 a 9 non-null int64
1 b 9 non-null int64
```
but spark pandas api return
```
Index: 9.0 entries, 0.6658222030375259 to 0.7862583284518239
Data columns (total 2 columns):
# Column Non-Null Count Dtype
--- ------ -------------- -----
0 a 9 non-null int64
1 b 9 non-null int64
```
So to align outputs I've done the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1524459310
Looks pretty good., but let's wait until the [initial pandas 2.0 support](https://github.com/apache/spark/pull/40658) is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40436:
URL: https://github.com/apache/spark/pull/40436#discussion_r1310668018
##########
python/pyspark/pandas/indexes/base.py:
##########
@@ -289,7 +289,7 @@ def _summary(self, name: Optional[str] = None) -> str:
if name is None:
name = type(self).__name__
- return "%s: %s entries%s" % (name, total_count, index_summary)
+ return "%s: %s entries%s" % (name, int(total_count), index_summary)
Review Comment:
qq: why do we need to fix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40436: [SPARK-42619][PS] Add `show_counts` parameter for DataFrame.info
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40436:
URL: https://github.com/apache/spark/pull/40436#issuecomment-1705803526
Thanks, @dzhigimont :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org