You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/12/02 22:32:08 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2426: syscfg: OS_TICKS_PER_SEC definition workaround
kasjer opened a new pull request #2426:
URL: https://github.com/apache/mynewt-core/pull/2426
OS_TICK_PER_SEC is configurable via syscfg in fe310/nrf52/stmf1.
nrf52 and stmf1 had this changed not so long ago.
Unfortunately the way it was defined:
#define OS_TICKS_PER_SEC MYNEWT_VAL(OS_TICKS_PER_SEC)
collides with existing usage where some other
syscfg values refer to definition OS_TICKS_PER_SEC
(not MYNEWT_VAL(..) which is not valid for all MCUs)
and that makes compilation fail with undefined MYNEWT_VAL() function.
If OS_TICKS_PER_SEC is to be configurable (and that seems reasonable
for many cases) it would be good to define it for all MCUs,
then change few yml files that refer to plain OS_TICKS_PER_SEC
to use MYNEWT_VAL() instead.
For now as workaround MYNEWT_VAL(OS_TICKS_PER_SEC) is expanded
in 3 files to avoid preprocessor problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2426: syscfg: OS_TICKS_PER_SEC definition workaround
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2426:
URL: https://github.com/apache/mynewt-core/pull/2426#issuecomment-760878066
Alternative solution applied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2426: syscfg: OS_TICKS_PER_SEC definition workaround
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2426:
URL: https://github.com/apache/mynewt-core/pull/2426#issuecomment-737536558
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer closed pull request #2426: syscfg: OS_TICKS_PER_SEC definition workaround
Posted by GitBox <gi...@apache.org>.
kasjer closed pull request #2426:
URL: https://github.com/apache/mynewt-core/pull/2426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org