You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/09/23 08:13:10 UTC
[GitHub] [incubator-doris] xy720 opened a new pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
xy720 opened a new pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658
## Proposed changes
Fix #4657
when a dynamic partitioned table is created, it will take some time to create the partitions, a exception needs to be thrown when users try to load data into this table
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658#discussion_r495464553
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java
##########
@@ -182,6 +182,13 @@ public String getTimezone() {
}
}
+ // If this is a dynamic partitioned table, it will take some time to create the partition after the
+ // table is created, a exception needs to be thrown here
+ if (partitionIds.isEmpty()) {
+ throw new LoadException("data cannot be inserted into table with emtpy partition. " +
Review comment:
I agree. I think we can change the error msg like:
```
data cannot be inserted into table with emtpy partition... Use `SHOW PARTITIONS FROM tbl` to see the currenty partitions of this table.
```
And also change the msg in error code `ERR_EMPTY_PARTITION_IN_TABLE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xy720 commented on a change in pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
Posted by GitBox <gi...@apache.org>.
xy720 commented on a change in pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658#discussion_r495469350
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java
##########
@@ -182,6 +182,13 @@ public String getTimezone() {
}
}
+ // If this is a dynamic partitioned table, it will take some time to create the partition after the
+ // table is created, a exception needs to be thrown here
+ if (partitionIds.isEmpty()) {
+ throw new LoadException("data cannot be inserted into table with emtpy partition. " +
Review comment:
ok. I will change the error msg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658#issuecomment-697213624
this bug has been fixed at PR: https://github.com/apache/incubator-doris/pull/4621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658#discussion_r493339458
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java
##########
@@ -182,6 +182,13 @@ public String getTimezone() {
}
}
+ // If this is a dynamic partitioned table, it will take some time to create the partition after the
+ // table is created, a exception needs to be thrown here
+ if (partitionIds.isEmpty()) {
+ throw new LoadException("data cannot be inserted into table with emtpy partition. " +
Review comment:
It is best to guide users in the prompt to wait for a while because of dynamic partitioning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4658: [Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4658:
URL: https://github.com/apache/incubator-doris/pull/4658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org