You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2013/12/05 01:16:21 UTC
Re: Review Request 15151: Better error reporting by async threads in
HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15151/
-----------------------------------------------------------
(Updated Dec. 5, 2013, 12:16 a.m.)
Review request for hive, Carl Steinbach, Prasad Mujumdar, and Thejas Nair.
Changes
-------
Fixed formatting issues.
Bugs: HIVE-5230
https://issues.apache.org/jira/browse/HIVE-5230
Repository: hive-git
Description
-------
[HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object).
Diffs (updated)
-----
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf
service/if/TCLIService.thrift 1f49445
service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386
service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874
service/src/java/org/apache/hive/service/cli/HiveSQLException.java 74e8b94
service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6
service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1
service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d
Diff: https://reviews.apache.org/r/15151/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 15151: Better error reporting by async threads in
HiveServer2
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15151/
-----------------------------------------------------------
(Updated Dec. 17, 2013, 5:34 a.m.)
Review request for hive, Carl Steinbach, Prasad Mujumdar, and Thejas Nair.
Changes
-------
Rebased on trunk with thrift files.
Bugs: HIVE-5230
https://issues.apache.org/jira/browse/HIVE-5230
Repository: hive-git
Description
-------
[HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object).
Diffs (updated)
-----
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java e420b75
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 37975e5
service/if/TCLIService.thrift 62a9730
service/src/gen/thrift/gen-cpp/TCLIService_types.h 853bb4c
service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 7ab1310
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java 1c44789
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java 497cc01
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java b5c3f01
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java 1cb5147
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java 8ab8297
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 688f790
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 8c6c4f0
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java 0b6772c
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java db2262d
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java 81c2f16
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java ff5e54d
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java 251f86a
service/src/gen/thrift/gen-py/TCLIService/ttypes.py 185ea5b
service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c94acbf
service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386
service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874
service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6
service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1
service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/Operation.java 5d1dd5f
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 296f8b3
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java c0e6151
service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 44d3130
service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d
Diff: https://reviews.apache.org/r/15151/diff/
Testing
-------
Thanks,
Vaibhav Gumashta