You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/27 17:51:06 UTC

[GitHub] sujith71955 commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC client

sujith71955 commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC client
URL: https://github.com/apache/spark/pull/23899#discussion_r260868321
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/ColumnValue.java
 ##########
 @@ -207,6 +207,14 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
     }
   }
 
+  private static TColumnValue getDecimalType(Object value) {
+    Object decV = value;
+      if (value instanceof BigDecimal) {
+        decV = HiveDecimal.create((BigDecimal)decV);
 
 Review comment:
   fixed. thanks :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org