[pulsar] branch master updated: Add `SkipCopyPythonClients` for building pulsar docker image (#3798)

[si...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 7d97043  Add `SkipCopyPythonClients` for building pulsar docker image (#3798)
7d97043 is described below

commit 7d97043d76174ecedf4060afbc49bf2ec4fc2ebd
Author: Sijie Guo <gu...@gmail.com>
AuthorDate: Mon Mar 11 13:10:23 2019 +0800

    Add `SkipCopyPythonClients` for building pulsar docker image (#3798)
    
    *Motivation*
    
    Currently we use `skipBuildPythonClients` for controlling both building
    python clients and copying python clients. So we have to disable or enable
    all together.
    
    This introduces a problem for building pulsar docker image
    in a kubernetes environment (either docker-in-docker or docker-out-of-docker).
    
    An alternative approach for building pulsar docker image in a k8s environment
    will be:
    
    - build python client for py27 using `apachepulsar/pulsar-build:manylinux-cp27-cp27mu`
      in a container
    - build python client for py35 using `apachepulsar/pulsar-build:manylinux-cp35-cp35m`
      in a container
    - build pulsar docker image
    
    This requires we separating building python clients from copying python clients.
    
    *Modifications*
    
    - introduce a new property `skipCopyPythonClients` to skip copying python clients
    - `skipBuildPythonClients` is only used for skipping building python clients
    
    So the above build process can be done by specifying `-DskipCopyPythonClients`
---
 docker/pulsar/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docker/pulsar/pom.xml b/docker/pulsar/pom.xml
index 3e631c3..af24f3b 100644
--- a/docker/pulsar/pom.xml
+++ b/docker/pulsar/pom.xml
@@ -97,7 +97,7 @@
                   <goal>run</goal>
                 </goals>
                 <configuration>
-                  <skip>${skipBuildPythonClient}</skip>
+                  <skip>${skipCopyPythonClients}</skip>
                   <tasks>
                     <echo>copy python wheel file</echo>
                     <mkdir dir="${basedir}/target/python-client"/>