You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Barry Oglesby <bo...@pivotal.io> on 2016/03/16 21:54:52 UTC
Review Request 44930: GEODE-1095: GatewaySenderEventImpl now caches
serialized value size
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44930/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and Dan Smith.
Repository: geode
Description
-------
GEODE-1095: GatewaySenderEventImpl now caches serialized value size
This is partly merged from a GemFire maintenance branch
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java d8922f874830831fff573f8f1a6a9ed09fbcfde8
Diff: https://reviews.apache.org/r/44930/diff/
Testing
-------
- repeatedly ran ParallelGatewaySenderOperation_2_OffHeapDUnitTest (along fixes for GEODE-670 and GEODE-1067)
- running precheckin
Thanks,
Barry Oglesby
Re: Review Request 44930: GEODE-1095: GatewaySenderEventImpl now
caches serialized value size
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44930/#review123934
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java (line 1230)
<https://reviews.apache.org/r/44930/#comment186264>
Since serializedValueSize is volatile only read it once instead of twice.
Read it into a local variable and then read and return it.
- Darrel Schneider
On March 16, 2016, 1:54 p.m., Barry Oglesby wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44930/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 1:54 p.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1095: GatewaySenderEventImpl now caches serialized value size
>
> This is partly merged from a GemFire maintenance branch
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java d8922f874830831fff573f8f1a6a9ed09fbcfde8
>
> Diff: https://reviews.apache.org/r/44930/diff/
>
>
> Testing
> -------
>
> - repeatedly ran ParallelGatewaySenderOperation_2_OffHeapDUnitTest (along fixes for GEODE-670 and GEODE-1067)
> - running precheckin
>
>
> Thanks,
>
> Barry Oglesby
>
>