You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/05 09:46:45 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #7167: [INLONG-7166][DataProxy] Fix audit data reporting
woofyzhao opened a new pull request, #7167:
URL: https://github.com/apache/inlong/pull/7167
- Fixes #7166
### Modifications
- add audit report for new mq sink
- fix concurrency issue on config operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao merged pull request #7167: [INLONG-7166][DataProxy] Fix audit data reporting
Posted by GitBox <gi...@apache.org>.
woofyzhao merged PR #7167:
URL: https://github.com/apache/inlong/pull/7167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] luchunliang commented on a diff in pull request #7167: [INLONG-7166][DataProxy] Fix audit data reporting
Posted by GitBox <gi...@apache.org>.
luchunliang commented on code in PR #7167:
URL: https://github.com/apache/inlong/pull/7167#discussion_r1062309646
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -238,6 +243,7 @@ public void onCompletion(RecordMetadata arg0, Exception ex) {
sinkContext.addSendResultMetric(event, topic, true, sendTime);
sinkContext.getDispatchQueue().release(event.getSize());
event.ack();
+ AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, event.getSimpleProfile());
Review Comment:
Repeat audit report.
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -193,6 +195,9 @@ public void onCompletion(RecordMetadata arg0, Exception ex) {
sinkContext.addSendResultMetric(event, topic, true, sendTime);
sinkContext.getDispatchQueue().release(event.getSize());
event.ack();
+ for (ProxyEvent auditEvent : event.getEvents()) {
+ AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, auditEvent);
Review Comment:
Repeat audit report.
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -280,6 +286,9 @@ public void onCompletion(RecordMetadata arg0, Exception ex) {
sinkContext.addSendResultMetric(event, topic, true, sendTime);
sinkContext.getDispatchQueue().release(event.getSize());
event.ack();
+ for (ProxyEvent auditEvent : event.getEvents()) {
+ AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, auditEvent);
+ }
Review Comment:
Repeat audit report.
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org