You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2019/04/02 08:15:25 UTC
[hadoop] branch trunk updated: HADOOP-16218. Findbugs warning of
null param to non-nullable method in Configuration with Guava update.
(#655)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 61d1911 HADOOP-16218. Findbugs warning of null param to non-nullable method in Configuration with Guava update. (#655)
61d1911 is described below
commit 61d19110d4dfdb67e7763ab5b2a603ca041e8830
Author: Steve Loughran <st...@apache.org>
AuthorDate: Tue Apr 2 09:15:11 2019 +0100
HADOOP-16218. Findbugs warning of null param to non-nullable method in Configuration with Guava update. (#655)
Change-Id: I461e518ce9a4730b91a8138ad55b39e9a4b0a4b8
---
.../src/main/java/org/apache/hadoop/conf/Configuration.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
index 272482b..2757f88 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
@@ -69,6 +69,7 @@ import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
+import javax.annotation.Nullable;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.stream.XMLInputFactory;
@@ -3512,7 +3513,7 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
* </ul>
* @param out the writer to write to.
*/
- public void writeXml(String propertyName, Writer out)
+ public void writeXml(@Nullable String propertyName, Writer out)
throws IOException, IllegalArgumentException {
Document doc = asXmlDocument(propertyName);
@@ -3534,7 +3535,7 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
/**
* Return the XML DOM corresponding to this Configuration.
*/
- private synchronized Document asXmlDocument(String propertyName)
+ private synchronized Document asXmlDocument(@Nullable String propertyName)
throws IOException, IllegalArgumentException {
Document doc;
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org