[PR] Fix non-atomic write in ShardBackupMetadata.store() that can destroy backup metadata [solr]

["markrmiller (via GitHub)" <gi...@apache.org>]

markrmiller opened a new pull request, #4444:
URL: https://github.com/apache/solr/pull/4444

   https://issues.apache.org/jira/browse/SOLR-18249
   
   The store() method deletes the existing metadata file before writing the replacement. If the write fails (disk full, network error, crash), both old and new metadata are lost, making the backup point permanently unrestorable. Removes the delete-before-write and relies on createOutput to overwrite, so the old file persists if the new write fails.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

Re: [PR] Fix non-atomic write in ShardBackupMetadata.store() that can destroy backup metadata [solr]

["markrmiller (via GitHub)" <gi...@apache.org>]

markrmiller closed pull request #4444: Fix non-atomic write in ShardBackupMetadata.store() that can destroy backup metadata
URL: https://github.com/apache/solr/pull/4444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org