[GitHub] [pinot] ankitsultana commented on a diff in pull request #10166: [multistage] add support for stage parallelism

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #10166:
URL: https://github.com/apache/pinot/pull/10166#discussion_r1088176235


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -97,7 +98,7 @@ public void assignWorkerToStage(int stageId, StageMetadata stageMetadata, long r
       stageMetadata.setServerInstances(new ArrayList<>(
           serverInstanceToSegmentsMap.keySet()
               .stream()
-              .map(server -> new VirtualServer(server, 0)) // for now, only use single virtual server
+              .map(server -> new VirtualServer(server, 0)) // the leaf stage only has one server, so always use 0 here

Review Comment:
   @agavra : I guess we'll revisit this later right? We may want to split the segments in a server across multiple virtual servers in a leaf stage later.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org