Re: Review Request: shindig atom API enhancements

[Ryan Baxter <rb...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10468/#review20421
-----------------------------------------------------------

Ship it!


Committed revision 1481024

- Ryan Baxter


On April 22, 2013, 8:24 a.m., Zhi Hong Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10468/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 8:24 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
> 
> 
> Description
> -------
> 
> Copied from https://reviews.apache.org/r/9535/
> We identified a few issues of the atom Social API implementation in Shindig:
> - The <link> url is output with the url as the content of the tag as opposed to a href attribute
> - The url chosen is the url of the event (an API URL) as opposed to the URL of the Object in the event
> - The url type is "self" (which is correct for 2. above, but largely useless) when it should be absent or "alternate" (in Atom these are semantically equivalent)
> 
> 
> This addresses bug SHINDIG-1906.
>     https://issues.apache.org/jira/browse/SHINDIG-1906
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomAuthor.java 1470391 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomEntry.java 1470391 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1470391 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomSummary.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomSummaryConverter.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/XStream081Configuration.java 1470391 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomId.xml 1470391 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1470391 
> 
> Diff: https://reviews.apache.org/r/10468/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Zhi Hong Yang
> 
>