You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "Aliaksei Sandryhaila (JIRA)" <ji...@apache.org> on 2016/02/01 16:51:39 UTC

[jira] [Updated] (PARQUET-481) Refactor and expand reader-test

     [ https://issues.apache.org/jira/browse/PARQUET-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aliaksei Sandryhaila updated PARQUET-481:
-----------------------------------------
    Description: 
reader-test currently tests with a single parquet file and only verifies that we can read it, not the correctness of the output.

Proposed changes:
- Expand it to work with multiple files
- Move tests for Scanner to scanner-test.cc
- Add method ParquetFileReader::JsonPrint() that prints a file contents in a json format, so we can consistently compare the output with the ground truth stored in parquet-cpp/data. This method will also be more handy than DebugPrint when we start working with nested columns.

  was:
reader-test currently tests with a single parquet file and only verifies that we can read it, not the correctness of the output.

Proposed changes:
- Move reader-test.cc to a separate directory parquet-cpp/tests (in the future, all unit tests will be located there)
- Expand it to work with multiple files
- Add method ParquetFileReader::JsonPrint() that prints a file contents in a json format, so we can consistently compare the output with the ground truth stored in parquet-cpp/data. This method will also be more handy than DebugPrint when we start working with nested columns.


> Refactor and expand reader-test
> -------------------------------
>
>                 Key: PARQUET-481
>                 URL: https://issues.apache.org/jira/browse/PARQUET-481
>             Project: Parquet
>          Issue Type: Sub-task
>          Components: parquet-cpp
>    Affects Versions: cpp-0.1
>            Reporter: Aliaksei Sandryhaila
>            Assignee: Aliaksei Sandryhaila
>             Fix For: cpp-0.1
>
>
> reader-test currently tests with a single parquet file and only verifies that we can read it, not the correctness of the output.
> Proposed changes:
> - Expand it to work with multiple files
> - Move tests for Scanner to scanner-test.cc
> - Add method ParquetFileReader::JsonPrint() that prints a file contents in a json format, so we can consistently compare the output with the ground truth stored in parquet-cpp/data. This method will also be more handy than DebugPrint when we start working with nested columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)