[Bug 7164] TxRep undef warnings

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7164

gessel@blackrosetech.com <ge...@blackrosetech.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gessel@blackrosetech.com

--- Comment #15 from gessel@blackrosetech.com <ge...@blackrosetech.com> ---
I tried 1720440
(https://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/TxRep.pm?revision=1720440&view=markup)
which solves the undef value error in this bug, as noted in line 1420: 

#    #Bug 7164, trying to find out reason for these: _WARN: Use of
uninitialized value $msgscore in addition (+) at
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Plugin/TxRep.pm line 1415.

However, another mod, at line 1633 causes a 61x slowdown.  

  # disabled per bug 7191
  # return 1 unless (!defined $self->{default_storage});

Which is the fix for this bug:
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7191

I found this slowdown made sa-learn unusable.  reverting this patch resulted in
a net 2.1x slowdown over the default version in FreeBSD but without the errors.
 I am not seeing any misattribution errors as described in #7191 and there are
other fixes relative to the version that ships with FreeBSD.  

I've attached a diff file to 7191  It is trivial:

--- TxRep.pm.1720440    2017-12-19 07:53:56.837268934 -0800
+++ TxRep.pm.1720440.mod        2017-12-19 08:38:09.737087765 -0800
@@ -1630,7 +1630,8 @@
   my $self = shift;

   # disabled per bug 7191
-  # return 1 unless (!defined $self->{default_storage});
+  # Enabled per bug 7191 comment 18
+  return 1 unless (!defined $self->{default_storage});

   my $factory;
   if ($self->{main}->{pers_addr_list_factory}) {

-- 
You are receiving this mail because:
You are the assignee for the bug.