You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/12 13:10:09 UTC

[GitHub] [hadoop] iwasakims commented on pull request #2149: HADOOP-13230. S3A to optionally retain directory markers

iwasakims commented on pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#issuecomment-672860512


   It looks good to me overall as I did not see relevant integration tests failures with the patch applied. It is a bit confusing that there are `Parameterized` tests covering both keep and delete in addition to `-Dmarkers` option while we need both.
   
   It would help reviewing to split s3guard related part and performance tests to follow-up JIRAs. We can commit essential part first if it retains present default (DELETE) behaviour.
   
   `mvn verify -Dtest=x` on trunk:
   ```
   [ERROR] Errors: 
   [ERROR]   ITestS3AConfiguration.testAutomaticProxyPortSelection:190->expectFSCreateFailure:159->lambda$expectFSCreateFailure$0:161 » AccessDenied
   [ERROR]   ITestS3ATemporaryCredentials.testInvalidSTSBinding:257 » SdkClient Unable to f...
   [ERROR]   ITestS3ATemporaryCredentials.testSTS:130 » SdkClient Unable to find a region v...
   [ERROR]   ITestS3ATemporaryCredentials.testSessionRequestExceptionTranslation:441->lambda$testSessionRequestExceptionTranslation$5:442 » SdkClient
   [ERROR]   ITestS3ATemporaryCredentials.testSessionTokenExpiry:222 » SdkClient Unable to ...
   [ERROR]   ITestS3ATemporaryCredentials.testSessionTokenPropagation:193 » SdkClient Unabl...
   [ERROR]   ITestDirectoryCommitProtocol>ITestStagingCommitProtocol.setup:67->AbstractITCommitProtocol.setup:160->AbstractITCommitProtocol.cleanupDestDir:120->AbstractCommitITest.rmdir:164 » AccessDenied
   [INFO] 
   [ERROR] Tests run: 700, Failures: 0, Errors: 7, Skipped: 251
   ```
   
   `mvn verify -Dtest=x -Dmarkers=keep` with the patch applied:
   ```
   [ERROR] Failures: 
   [ERROR]   ITestSessionDelegationInFileystem.testDTUtilShell:719->dtutil:708->Assert.assertEquals:631->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 expected:<0> but was:<1>
   [ERROR] Errors: 
   [ERROR]   ITestS3AConfiguration.testAutomaticProxyPortSelection:190->expectFSCreateFailure:159->lambda$expectFSCreateFailure$0:161 » AccessDenied
   [ERROR]   ITestS3ATemporaryCredentials.testInvalidSTSBinding:257 » SdkClient Unable to f...
   [ERROR]   ITestS3ATemporaryCredentials.testSTS:130 » SdkClient Unable to find a region v...
   [ERROR]   ITestS3ATemporaryCredentials.testSessionRequestExceptionTranslation:441->lambda$testSessionRequestExceptionTranslation$5:442 » SdkClient
   [ERROR]   ITestS3ATemporaryCredentials.testSessionTokenExpiry:222 » SdkClient Unable to ...
   [ERROR]   ITestS3ATemporaryCredentials.testSessionTokenPropagation:193 » SdkClient Unabl...
   [ERROR]   ITestDelegatedMRJob.testJobSubmissionCollectsTokens:286 » SdkClient Unable to ...
   [ERROR]   ITestSessionDelegationInFileystem.testAddTokensFromFileSystem:239 » SdkClient ...
   [ERROR]   ITestSessionDelegationInFileystem.testCanRetrieveTokenFromCurrentUserCreds:264->createDelegationTokens:296->AbstractDelegationIT.mkTokens:88 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testDTCredentialProviderFromCurrentUserCreds:282->createDelegationTokens:296->AbstractDelegationIT.mkTokens:88 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testDelegatedFileSystem:312->createDelegationTokens:296->AbstractDelegationIT.mkTokens:88 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testDelegationBindingMismatch1:441->createDelegationTokens:296->AbstractDelegationIT.mkTokens:88 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testFileSystemBoundToCreator:690 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testGetDTfromFileSystem:216 » SdkClient Unab...
   [ERROR]   ITestSessionDelegationInFileystem.testHDFSFetchDTCommand:615->lambda$testHDFSFetchDTCommand$3:616 » SdkClient
   [ERROR]   ITestSessionDelegationInFileystem.testYarnCredentialPickup:585 » SdkClient Una...
   [ERROR]   ITestSessionDelegationTokens.testCreateAndUseDT:176 » SdkClient Unable to find...
   [ERROR]   ITestSessionDelegationTokens.testCreateWithRenewer:230 » SdkClient Unable to f...
   [ERROR]   ITestSessionDelegationTokens.testSaveLoadTokens:121 » SdkClient Unable to find...
   [INFO] 
   [ERROR] Tests run: 1349, Failures: 1, Errors: 19, Skipped: 521
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org