[GitHub] nwangtw commented on a change in pull request #3052: add back stmgr metrics

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3052: add back stmgr metrics
URL: https://github.com/apache/incubator-heron/pull/3052#discussion_r226797710
 
 

 ##########
 File path: heron/stmgr/src/cpp/manager/stmgr-server.cpp
 ##########
 @@ -30,37 +30,61 @@
 #include "network/network.h"
 #include "config/helper.h"
 #include "config/heron-internals-config-reader.h"
+#include "metrics/metrics.h"
 
 namespace heron {
 namespace stmgr {
 
 // Num data tuples received from other stream managers
 
 Review comment:
   Please add a comment about why we have to register these metrics one by one instead of registering the scope.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services