You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2012/11/05 20:34:12 UTC
[jira] [Created] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Gordon Sim created PROTON-120:
---------------------------------
Summary: Link.delivery() signature takes offset and size which are not used
Key: PROTON-120
URL: https://issues.apache.org/jira/browse/PROTON-120
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Affects Versions: 0.1, 0.2
Reporter: Gordon Sim
Priority: Minor
Fix For: 0.3
One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim reassigned PROTON-120:
---------------------------------
Assignee: Gordon Sim
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
> Attachments: delivery_signature.patch
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492400#comment-13492400 ]
Hiram Chirino commented on PROTON-120:
--------------------------------------
I would prefer if it did use the offset and size but as temporary solution you could just validate the offset ==0 and size == data.length and throw a IllegalArgumentException if it does not match. This keeps the API open to actually take advantage of the optimization that the API signature is suggesting apps use.
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
> Attachments: delivery_signature.patch
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492488#comment-13492488 ]
Gordon Sim commented on PROTON-120:
-----------------------------------
Ok, that sounds reasonable. I'll make the change as you suggest.
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
> Attachments: delivery_signature.patch
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-120:
------------------------------
Attachment: delivery_signature.patch
This patch changes the signature, removing the offset and size. The other option is to use the offset and size. If that route is intended, I can add a patch for that instead.
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
> Attachments: delivery_signature.patch
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492559#comment-13492559 ]
Hiram Chirino commented on PROTON-120:
--------------------------------------
looks good.
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492550#comment-13492550 ]
Gordon Sim commented on PROTON-120:
-----------------------------------
Revised patch available for review at https://reviews.apache.org/r/7935/ (or comment here if you prefer of course!).
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-120) Link.delivery() signature takes
offset and size which are not used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-120:
------------------------------
Attachment: (was: delivery_signature.patch)
> Link.delivery() signature takes offset and size which are not used
> ------------------------------------------------------------------
>
> Key: PROTON-120
> URL: https://issues.apache.org/jira/browse/PROTON-120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Minor
> Fix For: 0.3
>
>
> One option is that these should be used. Another is that they can be removed from the API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira