You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/22 23:39:05 UTC

[GitHub] piiswrong commented on a change in pull request #7421: Resolve more compile warnings

piiswrong commented on a change in pull request #7421: Resolve more compile warnings
URL: https://github.com/apache/incubator-mxnet/pull/7421#discussion_r134627096
 
 

 ##########
 File path: src/operator/bilinear_sampler.cc
 ##########
 @@ -28,7 +28,7 @@
 namespace mshadow {
 template<typename DType>
 bool between(DType value, int lowerBound, int upperBound) {
-  return (value >= lowerBound && value <= upperBound);
+  return (static_cast<int>(value) >= lowerBound && static_cast<int>(value) <= upperBound);
 
 Review comment:
   cast lowerbound and upperbound instead
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services