You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2020/04/11 11:33:50 UTC

[GitHub] [mesos] qianzhangxa edited a comment on issue #355: Handle EBUSY when destroying a cgroup.

qianzhangxa edited a comment on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612398466
 
 
   > > It seems the existing method `cgroups::remove` is not used anywhere except in the unit test codes, so do we still need it? Or we want to change it to internally call the `internal::remove` introduced in this PR?
   > 
   > Whatever you prefer :).
   
   Second thought, it seems not a good idea to make `cgroups::remove` internally call `internal::remove` since they have different return types, so let just leave it as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services