You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/02/16 18:08:36 UTC

Review Request 72138: ATLAS-3622: added authorization for add/remove of labels, update of namespace attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72138/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, keval bhatt, Abhay Kulkarni, Mandar Ambawane, mayank jain, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Pradeep Agrawal, Ramesh Mani, Sarath Subramanian, and Velmurugan Periasamy.


Bugs: ATLAS-3622
    https://issues.apache.org/jira/browse/ATLAS-3622


Repository: atlas


Description
-------

- added following privileges: ENTITY_ADD_LABEL, ENTITY_REMOVE_LABEL, ENTITY_UPDATE_NAMESPACE
- updated entity store to authroize changes to label and namespace attributes


Diffs
-----

  authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 951e5c9d3 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 38b68faa8 
  authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java e210958d2 
  authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java 485d4e861 
  authorization/src/main/resources/atlas-simple-authz-policy.json 0a5f0facd 
  authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java 16c8c8cec 
  authorization/src/test/resources/atlas-simple-authz-policy.json 5743de121 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java f511e2fc3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 113325d5d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 55c1cacf4 


Diff: https://reviews.apache.org/r/72138/diff/1/


Testing
-------

- pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1642/


Thanks,

Madhan Neethiraj


Re: Review Request 72138: ATLAS-3622: added authorization for add/remove of labels, update of namespace attributes

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72138/#review219604
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Feb. 16, 2020, 6:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72138/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2020, 6:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Abhay Kulkarni, Mandar Ambawane, mayank jain, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Pradeep Agrawal, Ramesh Mani, Sarath Subramanian, and Velmurugan Periasamy.
> 
> 
> Bugs: ATLAS-3622
>     https://issues.apache.org/jira/browse/ATLAS-3622
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - added following privileges: ENTITY_ADD_LABEL, ENTITY_REMOVE_LABEL, ENTITY_UPDATE_NAMESPACE
> - updated entity store to authroize changes to label and namespace attributes
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 951e5c9d3 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 38b68faa8 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java e210958d2 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java 485d4e861 
>   authorization/src/main/resources/atlas-simple-authz-policy.json 0a5f0facd 
>   authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java 16c8c8cec 
>   authorization/src/test/resources/atlas-simple-authz-policy.json 5743de121 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java c536f3b86 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 746193188 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 3c22d9a8c 
> 
> 
> Diff: https://reviews.apache.org/r/72138/diff/3/
> 
> 
> Testing
> -------
> 
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1643/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>