You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2025/01/28 22:32:11 UTC

[PR] Use project version for release-drafter [maven-gh-actions-shared]

slawekjaranowski opened a new pull request, #135:
URL: https://github.com/apache/maven-gh-actions-shared/pull/135

   Detecting version based on tags is not always accurate. 
   We can use project version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use project version for release-drafter [maven-gh-actions-shared]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #135:
URL: https://github.com/apache/maven-gh-actions-shared/pull/135#issuecomment-2620886616

   Is that related to `maven-plugin-testing` where the version used was `1.0.0` ?
   If so, I'm not sure the problem lies in tag/pom version detection, as I did fix a wrong reference:
   https://github.com/apache/maven-plugin-testing/commit/47317f68a8a890488fe32158f750526407a17eae
   Also, the log seems to indicate the problem is because it could not find a proper "last" release.  I think that's because there were only "pre-release" at GH (as they are betas).  I just changed the beta-2 to be the "last release", we'll see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use project version for release-drafter [maven-gh-actions-shared]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #135:
URL: https://github.com/apache/maven-gh-actions-shared/pull/135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use project version for release-drafter [maven-gh-actions-shared]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #135:
URL: https://github.com/apache/maven-gh-actions-shared/pull/135#issuecomment-2620897980

   Yes it is inspired by `maven-plugin-testing` ... detecting next version based of last tags is not accurate ... we can get current version from project.
   
   We will see how it will be works.
   
   In `maven-plugin-testing` we also have a two managed version from two branches ...
   The same is in compiler plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org