You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2010/10/07 22:46:17 UTC
svn commit: r1005622 -
/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
Author: doogie
Date: Thu Oct 7 20:46:17 2010
New Revision: 1005622
URL: http://svn.apache.org/viewvc?rev=1005622&view=rev
Log:
Replace 2 cases of string addition with StringBuilder.
Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java?rev=1005622&r1=1005621&r2=1005622&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java (original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java Thu Oct 7 20:46:17 2010
@@ -311,26 +311,26 @@ public class GenericDAO {
throw new org.ofbiz.entity.GenericNotImplementedException("Operation updateByCondition not supported yet for view entities");
}
- String sql = "UPDATE " + modelEntity.getTableName(datasourceInfo);
- sql += " SET ";
+ StringBuilder sql = new StringBuilder("UPDATE ").append(modelEntity.getTableName(datasourceInfo));
+ sql.append(" SET ");
List<ModelField> fieldList = new LinkedList<ModelField>();
boolean firstField = true;
for (String name: fieldsToSet.keySet()) {
ModelField field = modelEntity.getField(name);
if (field != null) {
if (!firstField) {
- sql += ", ";
+ sql.append(", ");
} else {
firstField = false;
}
- sql += field.getColName() + " = ?";
+ sql.append(field.getColName()).append(" = ?");
fieldList.add(field);
}
}
- sql += " WHERE " + condition.makeWhereString(modelEntity, null, this.datasourceInfo);
+ sql.append(" WHERE ").append(condition.makeWhereString(modelEntity, null, this.datasourceInfo));
try {
- sqlP.prepareStatement(sql);
+ sqlP.prepareStatement(sql.toString());
for (ModelField field: fieldList) {
Object value = fieldsToSet.get(field.getName());
SqlJdbcUtil.setValue(sqlP, field, modelEntity.getEntityName(), value, modelFieldTypeReader);
@@ -1147,15 +1147,15 @@ public class GenericDAO {
throw new org.ofbiz.entity.GenericNotImplementedException("Operation deleteByCondition not supported yet for view entities");
}
- String sql = "DELETE FROM " + modelEntity.getTableName(this.datasourceInfo);
+ StringBuilder sql = new StringBuilder("DELETE FROM ").append(modelEntity.getTableName(this.datasourceInfo));
String whereCondition = condition.makeWhereString(modelEntity, null, this.datasourceInfo);
if (UtilValidate.isNotEmpty(whereCondition)) {
- sql += " WHERE " + whereCondition;
+ sql.append(" WHERE ").append(whereCondition);
}
try {
- sqlP.prepareStatement(sql);
+ sqlP.prepareStatement(sql.toString());
return sqlP.executeUpdate();
} finally {