You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "janchilling (via GitHub)" <gi...@apache.org> on 2025/03/14 10:01:02 UTC
[PR] KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… [kafka]
janchilling opened a new pull request, #19208:
URL: https://github.com/apache/kafka/pull/19208
…pdater.enabled_ flag
Removed code of methods StreamThread#initializeAndRestorePhase and #initializeAndRestorePhase and related assertions in the tests, since they were only used in the negation flow.
Furthermore, with the following commit the dependency on the _state.updater.enabled_ flag has been removed from the StreamThread#runOnceWithoutProcessingThreads method.
Wanted to verify the changes done are in fact the correct ones from this commit, and the changes to completely remove the _state.updater.enabled_ flag will be done in future commits by taking the reviews into consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… [kafka]
Posted by "janchilling (via GitHub)" <gi...@apache.org>.
janchilling closed pull request #19208: KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u…
URL: https://github.com/apache/kafka/pull/19208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19208:
URL: https://github.com/apache/kafka/pull/19208#issuecomment-2744936633
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18913[WIP]: Removal of code guarded by the negation of _state.u… [kafka]
Posted by "janchilling (via GitHub)" <gi...@apache.org>.
janchilling commented on PR #19208:
URL: https://github.com/apache/kafka/pull/19208#issuecomment-2724229411
Hi @cadonna @mjsax,
I removed the code with the negation of _state.updater.enabled_ flag in the StreamThread#runOnceWithoutProcessingThreads method. So I removed methods StreamThread#initializeAndRestorePhase and TaskManager#tryToCompleteRestoration, since they were only called through the negation flow. Removed the assertions related to those methods in the Tests as well.
Can you please verify if my approach is correct? Like should I go deep into methods of this particular flow and remove code if its only used with this particular flow( Like I removed TaskManager#tryToCompleteRestoration in the first commit) or should I only remove code of the immediate methods guarded by the _state.updater.enabled_ flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org