You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/11/03 22:59:18 UTC
Review Request 27541: Revert "Adding resource consumption calculation
for cron jobs."
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27541/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
This reverts commit 37cb06335a834de1894c882810a822f5f2ef69bc.
Production consumption numbers clearly don't add up after this commit. Reverting it to investigate further.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 3e258127f452070214d5e9df9da25f5b38d0d886
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java e27a74b6498ae412fdfbe627859b7b68e06f08d2
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 4c4482cbf53afeb1ef733769f0aaf369109a0ea8
Diff: https://reviews.apache.org/r/27541/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 27541: Revert "Adding resource consumption
calculation for cron jobs."
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27541/#review59651
-----------------------------------------------------------
This patch does not apply cleanly on master (9ef905a), do you need to rebase?
- Aurora ReviewBot
On Nov. 3, 2014, 9:59 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27541/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 9:59 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit 37cb06335a834de1894c882810a822f5f2ef69bc.
>
> Production consumption numbers clearly don't add up after this commit. Reverting it to investigate further.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 3e258127f452070214d5e9df9da25f5b38d0d886
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java e27a74b6498ae412fdfbe627859b7b68e06f08d2
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 4c4482cbf53afeb1ef733769f0aaf369109a0ea8
>
> Diff: https://reviews.apache.org/r/27541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27541: Revert "Adding resource consumption
calculation for cron jobs."
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27541/#review59649
-----------------------------------------------------------
Ship it!
Please file and attach a ticket to this, can be done after committing.
- Bill Farner
On Nov. 3, 2014, 9:59 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27541/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 9:59 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit 37cb06335a834de1894c882810a822f5f2ef69bc.
>
> Production consumption numbers clearly don't add up after this commit. Reverting it to investigate further.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 3e258127f452070214d5e9df9da25f5b38d0d886
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java e27a74b6498ae412fdfbe627859b7b68e06f08d2
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 4c4482cbf53afeb1ef733769f0aaf369109a0ea8
>
> Diff: https://reviews.apache.org/r/27541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>