[jira] [Commented] (THRIFT-2810) Do not leave the underlying ServerSocket open if construction of TServerSocket fails

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205099#comment-14205099 ] 

ASF GitHub Bot commented on THRIFT-2810:
----------------------------------------

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/258#issuecomment-62427226
  
    https://issues.apache.org/jira/browse/THRIFT-2810


> Do not leave the underlying ServerSocket open if construction of TServerSocket fails
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2810
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2810
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.1
>            Reporter: Guido de Caso
>            Assignee: Guido de Caso
>             Fix For: 0.9.3
>
>
> If construction of a TServerSocket fails the underlying ServerSocket object may already have been initialized. Since the reference is nullified, we loose the opportunity to properly close it. This fix addresses the issue by always cleaning up after failures during construction.
> Additionally, the failure message is added to the exception for improved visibility of what went wrong



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)