You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/26 05:34:52 UTC

[GitHub] [ozone] kaijchen opened a new pull request, #3349: HDDS-6647. Address some flaky tests

kaijchen opened a new pull request, #3349:
URL: https://github.com/apache/ozone/pull/3349

   ## What changes were proposed in this pull request?
   
   Added flaky tag to some tests.
   
   1. HDDS-6335. TestParentAcl#testKeyAcl
   https://github.com/apache/ozone/runs/6168965490?check_suite_focus=true#step:5:1859
   
   2. HDDS-5819, HDDS-6451. TestRootedOzoneFileSystem#testRenameToTrashEnabled
   https://github.com/kaijchen/ozone/runs/6151453278?check_suite_focus=true#step:4:3038
   
   3. HDDS-6477, HDDS-6642. TestOzoneManagerHAMetadataOnly#testListVolumes:
   https://github.com/kaijchen/ozone/runs/6150362670?check_suite_focus=true#step:4:3142
   
   4. HDDS-6644. TestOzoneManagerHAMetadataOnly#testReadRequest:
   https://github.com/kaijchen/ozone/runs/6150362734?check_suite_focus=true#step:4:3558
   
   5. HDDS-6645. TestOzoneFileSystem#testTrash
   https://github.com/kaijchen/ozone/runs/6150521370?check_suite_focus=true#step:4:2934
   
   6. HDDS-6646. TestOzoneFileSystem#testRenameToTrashEnabled
   https://github.com/kaijchen/ozone/runs/6150521445?check_suite_focus=true#step:4:3454
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6647
   
   ## How was this patch tested?
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #3349: HDDS-6647. Tag some known flaky tests

Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3349:
URL: https://github.com/apache/ozone/pull/3349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kaijchen commented on a diff in pull request #3349: HDDS-6647. Tag some known flaky tests

Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3349:
URL: https://github.com/apache/ozone/pull/3349#discussion_r858352105


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java:
##########
@@ -1297,6 +1298,7 @@ public void testGetTrashRoots() throws IOException {
    * since fs.rename(src,dst,options) is enabled.
    */
   @Test
+  @Flaky("HDDS-6646")

Review Comment:
   Thanks for explaining.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on a diff in pull request #3349: HDDS-6647. Address some flaky tests

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3349:
URL: https://github.com/apache/ozone/pull/3349#discussion_r858297355


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java:
##########
@@ -1297,6 +1298,7 @@ public void testGetTrashRoots() throws IOException {
    * since fs.rename(src,dst,options) is enabled.
    */
   @Test
+  @Flaky("HDDS-6646")

Review Comment:
   `@Flaky` requires JUnit5-based tests.  `TestOzoneFileSystem` and its siblings are still on JUnit4, because they are heavily parameterized and need a significant refactoring (see HDDS-6152).
   
   We can add these tags, but expect the tests to be included in the non-flaky runs and not repeated in case of failure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org