You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2025/02/05 19:41:51 UTC
[PR] Error prone back from the dead [lucene]
rmuir opened a new pull request, #14201:
URL: https://github.com/apache/lucene/pull/14201
Error prone is failing with NoSuchMethodError on JDK21 at least, due to their use of internal compiler apis.
Upgrading to 2.33.0 fixes the issue. Upgrading to 2.34+ is not possible as you will then encounter a different incompatibility with the JDK compiler.
But this gets error-prone working again.
Closes #14200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Error prone back from the dead [lucene]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #14201:
URL: https://github.com/apache/lucene/pull/14201#issuecomment-2637881979
This looks fine.
I do think there are new rules that could be disabled like [DefaultLocale](https://errorprone.info/bugpattern/DefaultLocale)
We were keeping a list
https://github.com/apache/lucene/blob/main/gradle/validation/error-prone.gradle#L73
I understand what a PITA it is to keep that up to date and disable the unneeded rules though.
I can take a stab at it tomorrow most likely if it would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Error prone back from the dead [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14201:
URL: https://github.com/apache/lucene/pull/14201#issuecomment-2637895695
@risdenk yes that would absolutely be awesome and help us keep it all sorted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Error prone back from the dead [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #14201:
URL: https://github.com/apache/lucene/pull/14201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Error prone back from the dead [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14201:
URL: https://github.com/apache/lucene/pull/14201#issuecomment-2637932527
@risdenk thanks for looking. Will get this thing turned on again with hopefully less trouble than the previous version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Error prone back from the dead [lucene]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #14201:
URL: https://github.com/apache/lucene/pull/14201#issuecomment-2644461358
Took a little longer than expected but the followup is here - https://github.com/apache/lucene/pull/14216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org