You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/03 03:38:49 UTC
[GitHub] [iceberg] zhaomin1423 commented on a diff in pull request #5346: Substitute the method of PropertyUtil#propertyAsLong for IcebergSource#propertyAsLong
zhaomin1423 commented on code in PR #5346:
URL: https://github.com/apache/iceberg/pull/5346#discussion_r936205856
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -57,7 +57,7 @@ public static int propertyAsInt(Map<String, String> properties,
}
public static long propertyAsLong(Map<String, String> properties,
- String property, long defaultValue) {
+ String property, Long defaultValue) {
Review Comment:
Thanks for your opinion，have updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org