You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2012/03/16 20:52:45 UTC

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

On 03/16/2012 08:48 PM, ggregory@apache.org wrote:
> Author: ggregory
> Date: Fri Mar 16 19:48:48 2012
> New Revision: 1301719
> 
> URL: http://svn.apache.org/viewvc?rev=1301719&view=rev
> Log:
> Set issue to add, not fix.
> 
> Modified:
>     commons/proper/codec/trunk/src/changes/changes.xml
> 
> Modified: commons/proper/codec/trunk/src/changes/changes.xml
> URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1301719&r1=1301718&r2=1301719&view=diff
> ==============================================================================
> --- commons/proper/codec/trunk/src/changes/changes.xml (original)
> +++ commons/proper/codec/trunk/src/changes/changes.xml Fri Mar 16 19:48:48 2012
> @@ -35,7 +35,7 @@
>        <action dev="ggregory" type="fix" issue="CODEC-121" due-to="javajohn">
>          QuotedPrintableCodec does not support soft line break per the 'quoted-printable' example on Wikipedia
>        </action>
> -      <action dev="ggregory" type="fix" issue="CODEC-63" due-to="javajohn">
> +      <action dev="ggregory" type="add" issue="CODEC-63" due-to="javajohn">
>          Implement NYSIIS

I think it was originally reported by Henri, javajohn was the user who
requested the QuotedPrintableCodec update.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Mar 16, 2012 at 5:04 PM, Thomas Neidhart
<th...@gmail.com>wrote:

> On 03/16/2012 09:54 PM, Gary Gregory wrote:
>
> >> not exactly, there is a mistake ;-)
> >>
> >> CODEC-63 (NYSIIS) was initially reported (with patch) by Henri.
> >> CODEC-121 (QuotedPrintableCodec) was reported by javajohn.
> >>
> >> I did enquire myself for a due-to but rather giving the correct one for
> >> NYSIIS to Henri.
>
> s/did/did not/
>
> > Ah, I see (or not ;) Can you fix this up for us?
>
> done.
>
> > Thank you,
>
> You are welcome.
>
> I am still a bit hesitating to commit myself, as I am rather new to this
> component, so do not wonder when I write a message instead of changing
> it myself.
>

I understand, being cautious is appreciated :) It's always OK to talk and
ask questions on the ML.

Gary


>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

Posted by Thomas Neidhart <th...@gmail.com>.
On 03/16/2012 09:54 PM, Gary Gregory wrote:

>> not exactly, there is a mistake ;-)
>>
>> CODEC-63 (NYSIIS) was initially reported (with patch) by Henri.
>> CODEC-121 (QuotedPrintableCodec) was reported by javajohn.
>>
>> I did enquire myself for a due-to but rather giving the correct one for
>> NYSIIS to Henri.

s/did/did not/

> Ah, I see (or not ;) Can you fix this up for us?

done.

> Thank you,

You are welcome.

I am still a bit hesitating to commit myself, as I am rather new to this
component, so do not wonder when I write a message instead of changing
it myself.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Mar 16, 2012 at 4:06 PM, Thomas Neidhart
<th...@gmail.com>wrote:

> On 03/16/2012 08:59 PM, Gary Gregory wrote:
> > On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart
> > <th...@gmail.com>wrote:
> >
> >> On 03/16/2012 08:48 PM, ggregory@apache.org wrote:
> >>> Author: ggregory
> >>> Date: Fri Mar 16 19:48:48 2012
> >>> New Revision: 1301719
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1301719&view=rev
> >>> Log:
> >>> Set issue to add, not fix.
> >>>
> >>> Modified:
> >>>     commons/proper/codec/trunk/src/changes/changes.xml
> >>>
> >>> Modified: commons/proper/codec/trunk/src/changes/changes.xml
> >>> URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1301719&r1=1301718&r2=1301719&view=diff
> >>>
> >>
> ==============================================================================
> >>> --- commons/proper/codec/trunk/src/changes/changes.xml (original)
> >>> +++ commons/proper/codec/trunk/src/changes/changes.xml Fri Mar 16
> >> 19:48:48 2012
> >>> @@ -35,7 +35,7 @@
> >>>        <action dev="ggregory" type="fix" issue="CODEC-121"
> >> due-to="javajohn">
> >>>          QuotedPrintableCodec does not support soft line break per the
> >> 'quoted-printable' example on Wikipedia
> >>>        </action>
> >>> -      <action dev="ggregory" type="fix" issue="CODEC-63"
> >> due-to="javajohn">
> >>> +      <action dev="ggregory" type="add" issue="CODEC-63"
> >> due-to="javajohn">
> >>>          Implement NYSIIS
> >>
> >> I think it was originally reported by Henri, javajohn was the user who
> >> requested the QuotedPrintableCodec update.
> >>
> >
> >  javajohn is the reporter (see Jira) and you where the patch submitter so
> > marked "tn" as the due-to.
>
> not exactly, there is a mistake ;-)
>
> CODEC-63 (NYSIIS) was initially reported (with patch) by Henri.
> CODEC-121 (QuotedPrintableCodec) was reported by javajohn.
>
> I did enquire myself for a due-to but rather giving the correct one for
> NYSIIS to Henri.
>

Ah, I see (or not ;) Can you fix this up for us?

Thank you,
Gary

>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

Posted by Thomas Neidhart <th...@gmail.com>.
On 03/16/2012 08:59 PM, Gary Gregory wrote:
> On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
> 
>> On 03/16/2012 08:48 PM, ggregory@apache.org wrote:
>>> Author: ggregory
>>> Date: Fri Mar 16 19:48:48 2012
>>> New Revision: 1301719
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1301719&view=rev
>>> Log:
>>> Set issue to add, not fix.
>>>
>>> Modified:
>>>     commons/proper/codec/trunk/src/changes/changes.xml
>>>
>>> Modified: commons/proper/codec/trunk/src/changes/changes.xml
>>> URL:
>> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1301719&r1=1301718&r2=1301719&view=diff
>>>
>> ==============================================================================
>>> --- commons/proper/codec/trunk/src/changes/changes.xml (original)
>>> +++ commons/proper/codec/trunk/src/changes/changes.xml Fri Mar 16
>> 19:48:48 2012
>>> @@ -35,7 +35,7 @@
>>>        <action dev="ggregory" type="fix" issue="CODEC-121"
>> due-to="javajohn">
>>>          QuotedPrintableCodec does not support soft line break per the
>> 'quoted-printable' example on Wikipedia
>>>        </action>
>>> -      <action dev="ggregory" type="fix" issue="CODEC-63"
>> due-to="javajohn">
>>> +      <action dev="ggregory" type="add" issue="CODEC-63"
>> due-to="javajohn">
>>>          Implement NYSIIS
>>
>> I think it was originally reported by Henri, javajohn was the user who
>> requested the QuotedPrintableCodec update.
>>
> 
>  javajohn is the reporter (see Jira) and you where the patch submitter so
> marked "tn" as the due-to.

not exactly, there is a mistake ;-)

CODEC-63 (NYSIIS) was initially reported (with patch) by Henri.
CODEC-121 (QuotedPrintableCodec) was reported by javajohn.

I did enquire myself for a due-to but rather giving the correct one for
NYSIIS to Henri.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart
<th...@gmail.com>wrote:

> On 03/16/2012 08:48 PM, ggregory@apache.org wrote:
> > Author: ggregory
> > Date: Fri Mar 16 19:48:48 2012
> > New Revision: 1301719
> >
> > URL: http://svn.apache.org/viewvc?rev=1301719&view=rev
> > Log:
> > Set issue to add, not fix.
> >
> > Modified:
> >     commons/proper/codec/trunk/src/changes/changes.xml
> >
> > Modified: commons/proper/codec/trunk/src/changes/changes.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1301719&r1=1301718&r2=1301719&view=diff
> >
> ==============================================================================
> > --- commons/proper/codec/trunk/src/changes/changes.xml (original)
> > +++ commons/proper/codec/trunk/src/changes/changes.xml Fri Mar 16
> 19:48:48 2012
> > @@ -35,7 +35,7 @@
> >        <action dev="ggregory" type="fix" issue="CODEC-121"
> due-to="javajohn">
> >          QuotedPrintableCodec does not support soft line break per the
> 'quoted-printable' example on Wikipedia
> >        </action>
> > -      <action dev="ggregory" type="fix" issue="CODEC-63"
> due-to="javajohn">
> > +      <action dev="ggregory" type="add" issue="CODEC-63"
> due-to="javajohn">
> >          Implement NYSIIS
>
> I think it was originally reported by Henri, javajohn was the user who
> requested the QuotedPrintableCodec update.
>

 javajohn is the reporter (see Jira) and you where the patch submitter so
marked "tn" as the due-to.

Gary

>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory