You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2021/09/01 07:52:53 UTC

[kudu-CR] [tool] Support to dump and edit pbc in JSON pretty format

Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17808 )

Change subject: [tool] Support to dump and edit pbc in JSON pretty format
......................................................................

[tool] Support to dump and edit pbc in JSON pretty format

If using 'kudu pbc edit' tool to edit a large protobuf container file
which contains a single object, the editing content is in JSON compact
format which is hard for human reading.
This patch enhance 'pbc edit' tool to dump PBC content in JSON pretty
format by adding --json_pretty flag, and also for 'pbc dump' tool.

Change-Id: I6d404e6cd487a644fa848513670c4945bf789578
Reviewed-on: http://gerrit.cloudera.org:8080/17808
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
4 files changed, 370 insertions(+), 49 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d404e6cd487a644fa848513670c4945bf789578
Gerrit-Change-Number: 17808
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>