[GitHub] [accumulo] dlmarion commented on a diff in pull request #3292: fixes #3252 support tablets w/ and w/o location in tablet location cache

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3292:
URL: https://github.com/apache/accumulo/pull/3292#discussion_r1169966499


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/RootTabletLocator.java:
##########
@@ -132,10 +138,14 @@ protected TabletLocation getRootTabletLocation(ClientContext context) {
 
   @Override
   public TabletLocation locateTablet(ClientContext context, Text row, boolean skipRow,
-      boolean retry) {
+      HostingNeed hostingNeed) {
+    // only expect the hosted case so this code only handles that, so throw an exception is
+    // something else is seed

Review Comment:
   Comment is confusing. Why check the hostingNeed variable if it's never used in the method? Is it to prevent bugs in other parts of the codebase?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org