You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/29 01:42:00 UTC
[jira] [Commented] (NIFI-5245) SimpleCSVFileLookupService should
take account of charset.
[ https://issues.apache.org/jira/browse/NIFI-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492995#comment-16492995 ]
ASF GitHub Bot commented on NIFI-5245:
--------------------------------------
GitHub user ssogabe opened a pull request:
https://github.com/apache/nifi/pull/2744
NIFI-5245: SimpleCSVFileLookupService should take account of charset
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssogabe/nifi NiFi-5245
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2744
----
commit 3d3d604b1822104e8e4c0ee0177a98cd8bfd73ab
Author: Seiji Sogabe <s....@...>
Date: 2018-04-09T09:18:02Z
Merge tag 'rel/nifi-1.6.0'
NIFI-4995 signed release tag for approved release of NiFi 1.6.0
commit a3cfa9c3f2d2e9f3f437e515ae9a045bff83b143
Author: Seiji Sogabe <s....@...>
Date: 2018-04-26T03:33:43Z
Merge remote-tracking branch 'github/master'
commit fd6c855f166163416c355a0d581adb774bd8e106
Author: Seiji Sogabe <s....@...>
Date: 2018-05-28T09:59:34Z
Merge remote-tracking branch 'nifi/master'
commit 8d9ce01a3531a0d8d43342676a1bdb359c80be50
Author: Seiji Sogabe <s....@...>
Date: 2018-05-29T01:36:38Z
NiFi-5245: SimpleCSVFileLookupService should take account of charset
----
> SimpleCSVFileLookupService should take account of charset.
> ------------------------------------------------------------
>
> Key: NIFI-5245
> URL: https://issues.apache.org/jira/browse/NIFI-5245
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.6.0
> Environment: Windows 10
> Reporter: Seiji Sogabe
> Priority: Critical
>
> If charset of csv file is not default encoding on platform, SimpleCSVFileLookupService will lead to garbled characters.
> CSVRecordLookupService also has the same problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)