You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sean Owen (Commented) (JIRA)" <ji...@apache.org> on 2011/09/28 09:40:45 UTC
[jira] [Commented] (MAHOUT-821) MemoryDiffStorage mistake in
recommendable items method
[ https://issues.apache.org/jira/browse/MAHOUT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116271#comment-13116271 ]
Sean Owen commented on MAHOUT-821:
----------------------------------
Hmm, not sure I see the bug. The logic looks correct. Recommendable items are all items that the user does not already know about. So, an item is removed if there is a non-null pref from the user for that item. Which test here would test this -- it should not work if changed this way.
> MemoryDiffStorage mistake in recommendable items method
> -------------------------------------------------------
>
> Key: MAHOUT-821
> URL: https://issues.apache.org/jira/browse/MAHOUT-821
> Project: Mahout
> Issue Type: Bug
> Reporter: Lance Norskog
> Priority: Minor
> Attachments: short.patch
>
>
> The MemoryDiffStorage class has a "positive/negative" bug in building a list of "recommendable items". Attached patch fixes the bug and includes updates for various unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (MAHOUT-821) MemoryDiffStorage mistake in
recommendable items method
Posted by Lance Norskog <go...@gmail.com>.
Ah! Ok, didn't get that part.
On Wed, Sep 28, 2011 at 12:40 AM, Sean Owen (Commented) (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/MAHOUT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116271#comment-13116271]
>
> Sean Owen commented on MAHOUT-821:
> ----------------------------------
>
> Hmm, not sure I see the bug. The logic looks correct. Recommendable items
> are all items that the user does not already know about. So, an item is
> removed if there is a non-null pref from the user for that item. Which test
> here would test this -- it should not work if changed this way.
>
> > MemoryDiffStorage mistake in recommendable items method
> > -------------------------------------------------------
> >
> > Key: MAHOUT-821
> > URL: https://issues.apache.org/jira/browse/MAHOUT-821
> > Project: Mahout
> > Issue Type: Bug
> > Reporter: Lance Norskog
> > Priority: Minor
> > Attachments: short.patch
> >
> >
> > The MemoryDiffStorage class has a "positive/negative" bug in building a
> list of "recommendable items". Attached patch fixes the bug and includes
> updates for various unit tests.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Lance Norskog
goksron@gmail.com