You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by mmiklavc <gi...@git.apache.org> on 2018/11/19 22:22:19 UTC
[GitHub] metron pull request #1274: METRON-1887: Add logging to the ClasspathFunction...
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1274
METRON-1887: Add logging to the ClasspathFunctionResolver
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1887
From the Jira description:
We had a user reporting non-deterministic NPE's here - https://github.com/apache/metron/blob/master/metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java#L250. The purpose of this ticket is to more gracefully handle the NPE and add some additional debugging information to better track down the source of this issue should it come up again.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- n/a Have you written or updated unit tests and or integration tests to verify your changes?
- n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- n/a Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron METRON-1887-classpath-resolver
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1274
----
commit bfa7491f160abc3e01bb1c6f1c3927eb5cec7021
Author: justinleet <ju...@...>
Date: 2018-11-19T14:11:29Z
METRON-1872 Move rat plugin away from snapshot version (justinleet) closes apache/metron#1264
commit 0e50720da2c589ff0956164dfc71a12790205be4
Author: Michael Miklavcic <mi...@...>
Date: 2018-11-19T22:18:26Z
METRON-1887: Add logging to the ClasspathFunctionResolver
----
---
[GitHub] metron pull request #1274: METRON-1887: Add logging to the ClasspathFunction...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1274
---
[GitHub] metron pull request #1274: METRON-1887: Add logging to the ClasspathFunction...
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1274#discussion_r236430858
--- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/VFSClassloaderUtil.java ---
@@ -112,14 +112,18 @@ public static FileSystemManager generateVfs() throws FileSystemException {
* @throws FileSystemException
*/
public static Optional<ClassLoader> configureClassloader(String paths) throws FileSystemException {
+ LOG.debug("Configuring class loader with paths = {}", paths);
if(paths.trim().isEmpty()) {
--- End diff --
We haven't encountered any instances with path being null that I'm aware of - I'd like to start with this and add more checks as needed.
---
[GitHub] metron pull request #1274: METRON-1887: Add logging to the ClasspathFunction...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1274#discussion_r235121753
--- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/VFSClassloaderUtil.java ---
@@ -112,14 +112,18 @@ public static FileSystemManager generateVfs() throws FileSystemException {
* @throws FileSystemException
*/
public static Optional<ClassLoader> configureClassloader(String paths) throws FileSystemException {
+ LOG.debug("Configuring class loader with paths = {}", paths);
if(paths.trim().isEmpty()) {
--- End diff --
Should we add a null check here, just in case? Or use StringUtils.isBlank?
---
[GitHub] metron issue #1274: METRON-1887: Add logging to the ClasspathFunctionResolve...
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1274
Note - github is showing an extra commit from Apache for Justin that hasn't synced yet. Should hopefully be in sync soon.
---
[GitHub] metron issue #1274: METRON-1887: Add logging to the ClasspathFunctionResolve...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1274
One nit on a null check, but that is a pre-existing condition and does not seem to be directly related with the problem at hand. Dealer's choice on that one.
Either way, +1 looks good.
---