[GitHub] [pulsar] codelipenghui commented on pull request #17041: [monitoring][broker][metadata] add metadata store metrics

[GitBox <gi...@apache.org>]

codelipenghui commented on PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#issuecomment-1239381247

   @tjiuming 
   
   > Broker metadata store initialized before configuration metadata store, so, metadata-store-0 is broker metadata store and metadata-store-1 is configuration metadata store
   
   IMO, we should improve this part. Instead of adding docs to tell users which one is configuration store, and which one is metadata store, we should add the type to the metrics like `type=configuration/metadata`. I also consider adding the metadataStoreUrl, but it can be a long string value.
   
   And we should also add the `cluster` label. Users can have one Prometheus service for multiple clusters, e.g. https://github.com/apache/pulsar/wiki/PIP-8:-Pulsar-beyond-1M-topics


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org