You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/01/30 21:26:49 UTC
[GitHub] yaoliclshlmch commented on a change in pull request #3181: Add ci
script for building docker image
yaoliclshlmch commented on a change in pull request #3181: Add ci script for building docker image
URL: https://github.com/apache/incubator-heron/pull/3181#discussion_r252444108
##########
File path: scripts/ci/build_release_packages.sh
##########
@@ -51,11 +51,11 @@ chmod +x heron/tools/apiserver/src/shell/heron-apiserver.sh
bash scripts/release/status.sh
# Create a temporary director for generated files
-mkdir -p ~/heron-release
-rm -f ~/heron-release/*.*
-./docker/scripts/build-artifacts.sh $BUILD_OS $VERSION_TAG ~/heron-release
+mkdir -p $TEMP_RELEASE_DIR
+rm -f $TEMP_RELEASE_DIR/*.*
+./docker/scripts/build-artifacts.sh $BUILD_OS $VERSION_TAG rm -f $TEMP_RELEASE_DIR
Review comment:
Do you mean: ./docker/scripts/build-artifacts.sh $BUILD_OS $VERSION_TAG $TEMP_RELEASE_DIR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services