You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/10/17 19:07:25 UTC
Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843
Repository: ranger
Description
-------
Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
Diff: https://reviews.apache.org/r/63085/diff/1/
Testing
-------
Passes all unit tests. Tested with perf-tool locally.
Thanks,
Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188498
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 18, 2017, 1:03 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 1:03 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422d
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d5
>
>
> Diff: https://reviews.apache.org/r/63085/diff/3/
>
>
> Testing
> -------
>
> Passes all unit tests. Tested with perf-tool locally.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188547
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 18, 2017, 6:13 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 6:13 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d
>
>
> Diff: https://reviews.apache.org/r/63085/diff/4/
>
>
> Testing
> -------
>
> Passes all unit tests. Tested with perf-tool locally.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188568
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 18, 2017, 7:26 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 7:26 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d
>
>
> Diff: https://reviews.apache.org/r/63085/diff/5/
>
>
> Testing
> -------
>
> Passes all unit tests. Tested with perf-tool locally.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 7:26 p.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
Fixed bug uncovered by a failed unit test.
Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843
Repository: ranger
Description
-------
Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d
Diff: https://reviews.apache.org/r/63085/diff/5/
Changes: https://reviews.apache.org/r/63085/diff/4-5/
Testing
-------
Passes all unit tests. Tested with perf-tool locally.
Thanks,
Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 6:13 p.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
Addressed review comments
Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843
Repository: ranger
Description
-------
Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d
Diff: https://reviews.apache.org/r/63085/diff/4/
Changes: https://reviews.apache.org/r/63085/diff/3-4/
Testing
-------
Passes all unit tests. Tested with perf-tool locally.
Thanks,
Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188527
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
Lines 155 (patched)
<https://reviews.apache.org/r/63085/#comment265527>
Please add JavaDoc to new classes & methods.
- Alejandro Fernandez
On Oct. 18, 2017, 1:03 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 1:03 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422d
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d5
>
>
> Diff: https://reviews.apache.org/r/63085/diff/3/
>
>
> Testing
> -------
>
> Passes all unit tests. Tested with perf-tool locally.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 1:03 a.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
Clarified code.
Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843
Repository: ranger
Description
-------
Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422d
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d5
Diff: https://reviews.apache.org/r/63085/diff/3/
Changes: https://reviews.apache.org/r/63085/diff/2-3/
Testing
-------
Passes all unit tests. Tested with perf-tool locally.
Thanks,
Abhay Kulkarni
Re: Review Request 63085: Tag enricher performance improvement in
identifying tags for resource being accessed
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 11:32 p.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
More performance improvements
Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843
Repository: ranger
Description
-------
Performance improvements in RANGER-1771, in finding the policies for a given resource, should be made in tag-enricher as well - to optimize finding of tags applicable for a given resource.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 210eb3d
Diff: https://reviews.apache.org/r/63085/diff/2/
Changes: https://reviews.apache.org/r/63085/diff/1-2/
Testing
-------
Passes all unit tests. Tested with perf-tool locally.
Thanks,
Abhay Kulkarni