You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/09/23 16:03:18 UTC
[GitHub] [incubator-heron] surahman commented on a change in pull request #3710: [HERON-3707] ConfigMap Pod Template Support
surahman commented on a change in pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#discussion_r714944117
##########
File path: heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java
##########
@@ -386,7 +386,7 @@ private V1StatefulSet createStatefulSet(Resource containerResource, int numberOf
statefulSetSpec.selector(selector);
// create a pod template
- final V1PodTemplateSpec podTemplateSpec = loadPodFromTemplate();
+ final V1PodTemplateSpec podTemplateSpec = new V1PodTemplateSpec();
Review comment:
Hi @nwangtw, thank you! I have spun up a build/test Ubuntu18.04 Docker container on my machine and I get the following output with:
```bash
INFO: Elapsed time: 198.476s, Critical Path: 9.83s
INFO: 855 processes: 191 internal, 664 local.
INFO: Build completed successfully, 855 total actions
PASSED: //heron/stmgr/tests/cpp/server:stmgr_unittest (see /root/.cache/bazel/_bazel_root/f4ab758bd53020512013f7dfa13b6902/execroot/org_apache_heron/bazel-out/k8-fastbuild/testlogs/heron/stmgr/tests/cpp/server/stmgr_unittest/test.log)
INFO: From Testing //heron/stmgr/tests/cpp/server:stmgr_unittest
==================== Test output for //heron/stmgr/tests/cpp/server:stmgr_unittest:
Current working directory (to find stmgr logs) /root/.cache/bazel/_bazel_root/f4ab758bd53020512013f7dfa13b6902/execroot/org_apache_heron/bazel-out/k8-fastbuild/bin/heron/stmgr/tests/cpp/server/stmgr_unittest.runfiles/org_apache_heron
Using config file heron/config/src/yaml/conf/test/test_heron_internals.yaml
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from StMgr
[ RUN ] StMgr.test_pplan_decode
[ OK ] StMgr.test_pplan_decode (2011 ms)
[ RUN ] StMgr.test_tuple_route
[ OK ] StMgr.test_tuple_route (2009 ms)
[ RUN ] StMgr.test_custom_grouping_route
[ OK ] StMgr.test_custom_grouping_route (2008 ms)
[ RUN ] StMgr.test_back_pressure_instance
[ OK ] StMgr.test_back_pressure_instance (4010 ms)
[ RUN ] StMgr.test_spout_death_under_backpressure
[ OK ] StMgr.test_spout_death_under_backpressure (6149 ms)
[ RUN ] StMgr.test_back_pressure_stmgr
[ OK ] StMgr.test_back_pressure_stmgr (5004 ms)
[ RUN ] StMgr.test_back_pressure_stmgr_reconnect
[ OK ] StMgr.test_back_pressure_stmgr_reconnect (5033 ms)
[ RUN ] StMgr.test_tmanager_restart_on_new_address
[ OK ] StMgr.test_tmanager_restart_on_new_address (5014 ms)
[ RUN ] StMgr.test_tmanager_restart_on_same_address
[ OK ] StMgr.test_tmanager_restart_on_same_address (4016 ms)
[ RUN ] StMgr.test_metricsmgr_reconnect[ OK ] StMgr.test_metricsmgr_reconnect (3005 ms)
[ RUN ] StMgr.test_PatchPhysicalPlanWithHydratedTopology
[ OK ] StMgr.test_PatchPhysicalPlanWithHydratedTopology (0 ms)
[----------] 11 tests from StMgr (38260 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (38260 ms total)
[ PASSED ] 11 tests.
================================================================================
//heron/stmgr/tests/cpp/server:stmgr_unittest (cached) PASSED in 38.3s
INFO: Build completed successfully, 855 total actions
```
Re-running with the whole suite yields the following:
```bash
//heron/tmanager/tests/cpp/server:stateful_restorer_unittest (1/3 cached) FLAKY, failed in 2 out of 3 in 5.1s
Stats over 3 runs: max = 5.1s, min = 0.0s, avg = 1.7s, dev = 2.4s
```
What I can discern from the test logs is that all tests inclusive of `test_custom_grouping_route` pass, which indicates a timeout on `test_back_pressure_instance`:
https://github.com/apache/incubator-heron/blob/396f2b848da0f56dcfda1d917928358133851cf5/heron/stmgr/tests/cpp/server/stmgr_unittest.cpp#L960
I have refactored the code a little to make it more readable on the `dev` branch but that should not be causing this test to pass locally. I shall clean up the Git commit-tree and merge the changes on `dev` into the main feature branch to see if it now passes on the Travis CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org