You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/27 18:31:23 UTC

[GitHub] [camel-website] bvahdat opened a new pull request #550: 2 tiny adjustments

bvahdat opened a new pull request #550:
URL: https://github.com/apache/camel-website/pull/550


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] oscerd commented on a change in pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #550:
URL: https://github.com/apache/camel-website/pull/550#discussion_r584177542



##########
File path: layouts/partials/releases/camel.html
##########
@@ -30,6 +30,7 @@ <h2 id="maven"><a class="anchor" href="#maven"></a>Getting the Binaries using Ma
 <p>To use this release in a Spring Boot application, use the <code>camel-spring-boot-dependencies</code> Bill of Materials (BOM):
 <aside>
   <p><mark>Note:</mark> for Camel 3.0.0 and newer releases the <code>groupId</code> for Camel Spring Boot support changed from <code>org.apache.camel</code> to <code>org.apache.camel.springbooot</code>, so be sure to check that the appropriate <code>groupId</code> is used for the Camel version.</p>
+  <p><mark>Note:</mark> for Camel 3.8.0 and newer releases there is another BOM available with the <code>artifactId</code> of <code>camel-spring-boot-bom</code> which you could instead make use of. For details see <a href="/camel-spring-boot/latest/#_camel_spring_boot_bom_vs_camel_spring_boot_dependencies_bom">the corresponding documentation.</a></p>

Review comment:
       This should be autogenerated somewhere




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] github-actions[bot] commented on pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #550:
URL: https://github.com/apache/camel-website/pull/550#issuecomment-787123335


   🚀 Preview for 3c228f11de1cc4309c55c6fe969c895062bf7352 is available at https://pr-550--camel.netlify.app


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] oscerd merged pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #550:
URL: https://github.com/apache/camel-website/pull/550


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] github-actions[bot] commented on pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #550:
URL: https://github.com/apache/camel-website/pull/550#issuecomment-787119430


   🚀 Preview for 289b4cc7666d590212fe781f238e44ad08f4c4c5 is available at https://pr-550--camel.netlify.app


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] github-actions[bot] commented on pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #550:
URL: https://github.com/apache/camel-website/pull/550#issuecomment-787123999


   🚀 Preview for b0f6d0e475300d0ee697be61f435458f100891d9 is available at https://pr-550--camel.netlify.app


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] oscerd commented on a change in pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #550:
URL: https://github.com/apache/camel-website/pull/550#discussion_r584456522



##########
File path: layouts/partials/releases/camel.html
##########
@@ -30,6 +30,7 @@ <h2 id="maven"><a class="anchor" href="#maven"></a>Getting the Binaries using Ma
 <p>To use this release in a Spring Boot application, use the <code>camel-spring-boot-dependencies</code> Bill of Materials (BOM):
 <aside>
   <p><mark>Note:</mark> for Camel 3.0.0 and newer releases the <code>groupId</code> for Camel Spring Boot support changed from <code>org.apache.camel</code> to <code>org.apache.camel.springbooot</code>, so be sure to check that the appropriate <code>groupId</code> is used for the Camel version.</p>
+  <p><mark>Note:</mark> for Camel 3.8.0 and newer releases there is another BOM available with the <code>artifactId</code> of <code>camel-spring-boot-bom</code> which you could instead make use of. For details see <a href="/camel-spring-boot/latest/#_camel_spring_boot_bom_vs_camel_spring_boot_dependencies_bom">the corresponding documentation.</a></p>

Review comment:
       Yes, I meant to say the page is autogenerated, but it is just a one-shot generation, so it can be modified.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] bvahdat commented on a change in pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
bvahdat commented on a change in pull request #550:
URL: https://github.com/apache/camel-website/pull/550#discussion_r584253895



##########
File path: layouts/partials/releases/camel.html
##########
@@ -30,6 +30,7 @@ <h2 id="maven"><a class="anchor" href="#maven"></a>Getting the Binaries using Ma
 <p>To use this release in a Spring Boot application, use the <code>camel-spring-boot-dependencies</code> Bill of Materials (BOM):
 <aside>
   <p><mark>Note:</mark> for Camel 3.0.0 and newer releases the <code>groupId</code> for Camel Spring Boot support changed from <code>org.apache.camel</code> to <code>org.apache.camel.springbooot</code>, so be sure to check that the appropriate <code>groupId</code> is used for the Camel version.</p>
+  <p><mark>Note:</mark> for Camel 3.8.0 and newer releases there is another BOM available with the <code>artifactId</code> of <code>camel-spring-boot-bom</code> which you could instead make use of. For details see <a href="/camel-spring-boot/latest/#_camel_spring_boot_bom_vs_camel_spring_boot_dependencies_bom">the corresponding documentation.</a></p>

Review comment:
       Not sure if I get your point. There is also another note about `3.0.0` which gets displayed the same way even for the releases before `3.0.0`:
   
   https://camel.apache.org/releases/release-2.25.2/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] github-actions[bot] commented on pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #550:
URL: https://github.com/apache/camel-website/pull/550#issuecomment-787123078


   🚀 Preview for 7d0f815e612f953be6dd99a1565c60903b1799de is available at https://pr-550--camel.netlify.app


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] oscerd commented on a change in pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #550:
URL: https://github.com/apache/camel-website/pull/550#discussion_r584456522



##########
File path: layouts/partials/releases/camel.html
##########
@@ -30,6 +30,7 @@ <h2 id="maven"><a class="anchor" href="#maven"></a>Getting the Binaries using Ma
 <p>To use this release in a Spring Boot application, use the <code>camel-spring-boot-dependencies</code> Bill of Materials (BOM):
 <aside>
   <p><mark>Note:</mark> for Camel 3.0.0 and newer releases the <code>groupId</code> for Camel Spring Boot support changed from <code>org.apache.camel</code> to <code>org.apache.camel.springbooot</code>, so be sure to check that the appropriate <code>groupId</code> is used for the Camel version.</p>
+  <p><mark>Note:</mark> for Camel 3.8.0 and newer releases there is another BOM available with the <code>artifactId</code> of <code>camel-spring-boot-bom</code> which you could instead make use of. For details see <a href="/camel-spring-boot/latest/#_camel_spring_boot_bom_vs_camel_spring_boot_dependencies_bom">the corresponding documentation.</a></p>

Review comment:
       Yes, I meant to say the page is autogenerated, but it is just a one-shot generation, so it could be modified.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] github-actions[bot] commented on pull request #550: 2 tiny adjustments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #550:
URL: https://github.com/apache/camel-website/pull/550#issuecomment-787125477


   🚀 Preview for f61c0eef4f68c8815c0619f70a0a8a1b03a41cd9 is available at https://pr-550--camel.netlify.app


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org