[GitHub] [lucene-solr] mikemccand commented on a change in pull request #606: LUCENE-8671: Allow more fine-grained control over off-heap term dictionaries

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #606: LUCENE-8671: Allow more fine-grained control over off-heap term dictionaries
URL: https://github.com/apache/lucene-solr/pull/606#discussion_r264770361
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersIndexInput.java
 ##########
 @@ -193,5 +193,10 @@ private void ensureOpen() {
     if (in == null) {
       throw new AlreadyClosedException("Already closed.");
     }
-  }  
+  }
+
+  @Override
+  public boolean isMMapped() {
+    return true;
 
 Review comment:
   Maybe we can remove this method, and move this defaulting logic into the creation of the `IOContext`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org