You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 19:07:30 UTC
[GitHub] [incubator-nuttx] Palmitoxico opened a new pull request #1835: Fix build errors when using DEBUGASSERT
Palmitoxico opened a new pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835
## Summary
Wrong variable names used inside DEBUGASSERT macros causes build errors when building with debug assertions enabled.
## Impact
This PR should fix these build errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1835: Fix build errors when using DEBUGASSERT
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Palmitoxico commented on pull request #1835: Fix build errors when using DEBUGASSERT
Posted by GitBox <gi...@apache.org>.
Palmitoxico commented on pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694850414
Should be fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1835: Fix build errors when using DEBUGASSERT
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694609312
@Palmitoxico could you fix these warnings too:
```
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/drivers/rf/dat-31r5-sp.c:192:78: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/drivers/rf/dat-31r5-sp.c:221:78: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/drivers/rf/dat-31r5-sp.c:272:82: error: Long line found
```
Yes, it isn't your fault, but the community agree that the contributor has to fix all style issues in the touched files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Palmitoxico commented on pull request #1835: Fix build errors when using DEBUGASSERT
Posted by GitBox <gi...@apache.org>.
Palmitoxico commented on pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694837474
Oh I'll fix that. It is my fault though (I'm the original author of this file).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org