You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/27 00:22:01 UTC

[jira] [Commented] (GEODE-3894) Create HandshakeRequest

    [ https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221502#comment-16221502 ] 

ASF GitHub Bot commented on GEODE-3894:
---------------------------------------

WireBaron opened a new pull request #985: GEODE-3894: Create HandshakeRequest
URL: https://github.com/apache/geode/pull/985
 
 
   added connection state processors to inject protocol state specific
   functionality refactored existing authentication and authorization flows to use
   connection state processors added new handshake message, handler, and state
   processor
   
   Signed-off-by: Bruce Schuchardt <bs...@pivotal.io>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   @kohlmu-pivotal @galen-pivotal @PivotalSarge @bschuchardt 
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create HandshakeRequest
> -----------------------
>
>                 Key: GEODE-3894
>                 URL: https://issues.apache.org/jira/browse/GEODE-3894
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way other requests are handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)