[GitHub] [airflow] alexandermalyga commented on a diff in pull request #29314: Add ttlSecondsAfterFinished to migrateDatabaseJob and createUserJob

["alexandermalyga (via GitHub)" <gi...@apache.org>]

alexandermalyga commented on code in PR #29314:
URL: https://github.com/apache/airflow/pull/29314#discussion_r1094788115


##########
chart/templates/jobs/create-user-job.yaml:
##########
@@ -48,6 +48,9 @@ metadata:
     {{- $annotations | toYaml | nindent 4 }}
   {{- end }}
 spec:
+  {{- if not (kindIs "invalid" .Values.createUserJob.ttlSecondsAfterFinished) }}

Review Comment:
   Checking specifically for `not nil` because `0` is a valid value for this field and it would evaluate to false normally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org