You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/20 18:54:39 UTC

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3410

to review the following change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................

tablet: fix sloppiness around atomic mutation lists

Previously we had some TSAN suppressions around our handling of
the Mutation linked lists. This removes them and does the appropriate
Acquire_Loads that we were missing.

In practice I don't think we were hitting any bugs due to this, but
it's hard to know -- maybe this was a cause of some recent crashes?
Either way, fewer suppressions is better.

Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
---
M build-support/tsan-suppressions.txt
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mutation.cc
M src/kudu/tablet/mutation.h
6 files changed, 23 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3410/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1887/

-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3410/1/src/kudu/tablet/memrowset.h
File src/kudu/tablet/memrowset.h:

Line 79:   Mutation* acquire_redo_head() {
> not clear enough given it's a one-line implementation?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3410

to look at the new patch set (#2).

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................

tablet: fix sloppiness around atomic mutation lists

Previously we had some TSAN suppressions around our handling of
the Mutation linked lists. This removes them and does the appropriate
Acquire_Loads that we were missing.

In practice I don't think we were hitting any bugs due to this, but
it's hard to know -- maybe this was a cause of some recent crashes?
Either way, fewer suppressions is better.

Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
---
M build-support/tsan-suppressions.txt
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mutation.cc
M src/kudu/tablet/mutation.h
6 files changed, 25 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3410/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3410/1/src/kudu/tablet/memrowset.h
File src/kudu/tablet/memrowset.h:

Line 79:   Mutation* acquire_redo_head() {
docs


-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


tablet: fix sloppiness around atomic mutation lists

Previously we had some TSAN suppressions around our handling of
the Mutation linked lists. This removes them and does the appropriate
Acquire_Loads that we were missing.

In practice I don't think we were hitting any bugs due to this, but
it's hard to know -- maybe this was a cause of some recent crashes?
Either way, fewer suppressions is better.

Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Reviewed-on: http://gerrit.cloudera.org:8080/3410
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/tsan-suppressions.txt
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mutation.cc
M src/kudu/tablet/mutation.h
6 files changed, 25 insertions(+), 15 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1924/

-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1:

(1 comment)

The non-acquire loads are safe _assuming that the compiler doesn't re-order anything_. It seems unlikely that the compiler would reorder in this case, but... I wouldn't bet my life on it. Note that acquire_load on x86 is just a normal load with a 'compiler barrier', not any different assembly instruction.

http://gerrit.cloudera.org:8080/#/c/3410/1/src/kudu/tablet/memrowset.h
File src/kudu/tablet/memrowset.h:

Line 79:   Mutation* acquire_redo_head() {
> docs
not clear enough given it's a one-line implementation?


-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1: Code-Review+2

Change looks fine, but the comment you wrote in tsan-suppressions.txt seemed to suggest (fairly confidently) that the non-acquire based loads were safe, due to the x86 TSO. Has your thinking on that changed since then?

Also, is there an effect on performance?

-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No