You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 05:54:04 UTC

[GitHub] [flink] kl0u commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

kl0u commented on pull request #13808:
URL: https://github.com/apache/flink/pull/13808#issuecomment-717715756


   Yes @guoweiM , I think it is better to introduce a change with the commit that uses it. It is nice for commits to be self-contained so that if something goes wrong, we can easily find when and why a change was introduced. Splitting the introduction of a change from its use or its tests makes it more difficult to trace back why it was introduced and what are its implications :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org