You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/12/31 01:09:46 UTC

[jira] Created: (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?

Is HttpSessionManager::purge_keepalives()  too aggressive?
----------------------------------------------------------

                 Key: TS-608
                 URL: https://issues.apache.org/jira/browse/TS-608
             Project: Traffic Server
          Issue Type: Bug
          Components: HTTP
            Reporter: Leif Hedstrom
             Fix For: 2.1.6


It seems that if we trigger the "max server connections", we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each "bucket" or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] [Updated] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?

Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-608:
-----------------------------

    Fix Version/s:     (was: 3.1.1)
                   3.3.0
    
> Is HttpSessionManager::purge_keepalives()  too aggressive?
> ----------------------------------------------------------
>
>                 Key: TS-608
>                 URL: https://issues.apache.org/jira/browse/TS-608
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>             Fix For: 3.3.0
>
>         Attachments: TS-608.patch
>
>
> It seems that if we trigger the "max server connections", we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each "bucket" or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-608:
-----------------------------

    Fix Version/s:     (was: 2.1.6)
                   3.1

Moving these to v3.1 (next dev release after v3.0), please reassign if you will work on this for v2.1.6 / v3.0.

> Is HttpSessionManager::purge_keepalives()  too aggressive?
> ----------------------------------------------------------
>
>                 Key: TS-608
>                 URL: https://issues.apache.org/jira/browse/TS-608
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>             Fix For: 3.1
>
>
> It seems that if we trigger the "max server connections", we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each "bucket" or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?

Posted by "mohan_zl (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976179#action_12976179 ] 

mohan_zl commented on TS-608:
-----------------------------

Now we are writing a l7 health check module, and i agree with your idea. Maybe we can do it when finish current work, if it is not very urgent.

> Is HttpSessionManager::purge_keepalives()  too aggressive?
> ----------------------------------------------------------
>
>                 Key: TS-608
>                 URL: https://issues.apache.org/jira/browse/TS-608
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>             Fix For: 2.1.6
>
>
> It seems that if we trigger the "max server connections", we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each "bucket" or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?

Posted by "mohan_zl (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mohan_zl updated TS-608:
------------------------

    Attachment: TS-608.patch

change the logic:
1 if we trigger "max server connections", remove one keep-alive connections from every dlist of every session bucket in HttpSessionManager
2 if we trigger per-origin limits, just remove all connections related with that origin server

> Is HttpSessionManager::purge_keepalives()  too aggressive?
> ----------------------------------------------------------
>
>                 Key: TS-608
>                 URL: https://issues.apache.org/jira/browse/TS-608
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>             Fix For: 3.1
>
>         Attachments: TS-608.patch
>
>
> It seems that if we trigger the "max server connections", we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each "bucket" or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.