You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Deepak Garg <de...@gmail.com> on 2012/08/22 10:19:38 UTC

Review Request: CloudStack CS-16052 Introducing data-base indexes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6725/
-----------------------------------------------------------

Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay Venkatachalam.


Description
-------

CloudStack CS-16052
Introducing data-base indexes


> >> 3. Any indexes at all on these new tables? 


This addresses bug CS-16052.


Diffs
-----

  setup/db/create-schema.sql 8129a6c 

Diff: https://reviews.apache.org/r/6725/diff/


Testing
-------

Manually tested on my setup.


Thanks,

Deepak Garg


Re: Review Request: CloudStack CS-16052 Introducing data-base indexes.

Posted by Vijay Venkatachalam <vi...@citrix.com>.

> On Aug. 23, 2012, 7:06 a.m., Vijay Venkatachalam wrote:
> > Ship It!

Db changes for index looks fine, ship it!


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6725/#review10676
-----------------------------------------------------------


On Aug. 22, 2012, 8:19 a.m., Deepak Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6725/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8:19 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay Venkatachalam.
> 
> 
> Description
> -------
> 
> CloudStack CS-16052
> Introducing data-base indexes
> 
> 
> > >> 3. Any indexes at all on these new tables? 
> 
> 
> This addresses bug CS-16052.
> 
> 
> Diffs
> -----
> 
>   setup/db/create-schema.sql 8129a6c 
> 
> Diff: https://reviews.apache.org/r/6725/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on my setup.
> 
> 
> Thanks,
> 
> Deepak Garg
> 
>


Re: Review Request: CloudStack CS-16052 Introducing data-base indexes.

Posted by Vijay Venkatachalam <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6725/#review10676
-----------------------------------------------------------

Ship it!


Ship It!

- Vijay Venkatachalam


On Aug. 22, 2012, 8:19 a.m., Deepak Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6725/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8:19 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay Venkatachalam.
> 
> 
> Description
> -------
> 
> CloudStack CS-16052
> Introducing data-base indexes
> 
> 
> > >> 3. Any indexes at all on these new tables? 
> 
> 
> This addresses bug CS-16052.
> 
> 
> Diffs
> -----
> 
>   setup/db/create-schema.sql 8129a6c 
> 
> Diff: https://reviews.apache.org/r/6725/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on my setup.
> 
> 
> Thanks,
> 
> Deepak Garg
> 
>


Re: Review Request: CloudStack CS-16052 Introducing data-base indexes.

Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6725/#review10683
-----------------------------------------------------------


Merged the changes with asf/autoscale as per Vijay's request.

- Pranav Saxena


On Aug. 22, 2012, 8:19 a.m., Deepak Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6725/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8:19 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay Venkatachalam.
> 
> 
> Description
> -------
> 
> CloudStack CS-16052
> Introducing data-base indexes
> 
> 
> > >> 3. Any indexes at all on these new tables? 
> 
> 
> This addresses bug CS-16052.
> 
> 
> Diffs
> -----
> 
>   setup/db/create-schema.sql 8129a6c 
> 
> Diff: https://reviews.apache.org/r/6725/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on my setup.
> 
> 
> Thanks,
> 
> Deepak Garg
> 
>